WDscholia / scholia

Wikidata-based scholarly profiles
https://scholia.toolforge.org
Other
215 stars 78 forks source link

three new aspects: podcast. - episode, and - season) #2413

Closed egonw closed 5 months ago

egonw commented 5 months ago

See https://github.com/WDscholia/scholia/issues/2414

Description

Implements aspects for podcasts.

Caveats

The current PR has reasonable stubs, but particularly the podcast episode aspect is a bit boring right now.

Codacy Warning

The current PR causes a Codacy warning for a line of code where a random call is made for the "Random podcast" button, following the approach of other random buttons:

image

I assume this risk is acceptable. I cannot think of an attack using this approach, e.g. allowing people to also end up on an advertisement item in Wikidata. Nor worse.

If you make changes to the Python code

Testing

The podcast index page has a number of examples: http://127.0.0.1:8100/podcast/ (see below screenshot)

Checklist

egonw commented 5 months ago

Some initial screenshots. First, for a podcast:

image image

The index page:

image

An episode:

image

egonw commented 5 months ago

Screenshot of the new language feature:

image

egonw commented 5 months ago

Okay, that should do it. I declare this version "feature complete" for a launch. @fnielsen, @Daniel-Mietchen, your review is most welcome.