WDscholia / scholia

Wikidata-based scholarly profiles
https://scholia.toolforge.org
Other
215 stars 77 forks source link

Ensure Article Titles with Dashes are Handled Appropriately for Identified Papers #2426

Closed faresh9 closed 3 months ago

faresh9 commented 4 months ago

Fixes #2420

Description

This PR modifies the code to ensure that article titles containing a dash are only replaced with a colon if the article is not identified. If the article is identified after the modification, the modified title is used; otherwise, the original title with the dash is retained.

Caveats

No caveats.

Testing

  1. Test with an identified article containing a dash in the title.
  2. Test with an unidentified article containing a dash in the title.
  3. Verify that the title modification behaves as expected in both cases.

Checklist

faresh9 commented 4 months ago

Everything should be good now

fnielsen commented 3 months ago

There were styling errors that flake8 reported, therefore https://github.com/WDscholia/scholia/pull/2440