Add support for DOI to QuickStatements

carlinmack commented 6 months ago

Rebased version of #2340

If/when this is merged I will rebase the others :)

Description

Please include a summary of the change, relevant motivation and context. If possible and applicable, include before and after screenshots and a URL where the changes can be seen.

Introduces DOI to QuickStatements (using the Crossref API) resulting in renaming the tool to Identifier to QuickStatements.

Note that this does not affect the current /doi/[doi] tool which creates QuickStatements using Citations.js and has different behaviour.

Caveats

Please list anything which has been left out of this PR or which should be considered before this PR is accepted Check any of the following which apply:

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
- [ ] I have made corresponding changes to the documentation
[ ] This change requires new dependencies (please list)

If you make changes to the Python code

[ ] My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

I tested using identifiers found in Wikidata and not
I created a test in test_utils.py to test the changes I made to string_to_type

Checklist

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[x] I have not used code from external sources without attribution
[x] I have considered accessibility in my implementation
[x] There are no remaining debug statements (print, console.log, ...)

carlinmack commented 6 months ago

If you think the code could be better written, can you please save rewriting until we merge the three following PRs! it makes rebasing so much more complicated

fnielsen commented 6 months ago

I get a "NameError: name 'string_to_arxivs' is not defined" with copy and paste of "https://arxiv.org/abs/2403.19856" into the main search interface http://127.0.0.1:8100/search?q=https://arxiv.org/abs/2403.19856

fnielsen commented 6 months ago

This http://127.0.0.1:8100/search?q=ilbert,%20S.,%20Fiesler,%20C.%20&%20Zimmer,%20M.%20Soc.%20Media%20Soc.%20https://doi.org/10.1177/20563051211019004%20(2021). results in the same error.

fnielsen commented 6 months ago

I often just copy-and-paste, e.g., "https://arxiv.org/abs/2403.19856" or part of a DOI, e.g., "org/10.1038/d41586-024-00901-3". As far as I can tell that functionality is lost.

fnielsen commented 6 months ago

There is lost of flake8 errors with flake8 scholia

carlinmack commented 5 months ago

This PR doesn't do anything to the main search interface: I am simply modifying the arxiv to quickstatements tool to be [doi, arxiv] to quickstatements. Therefore I don't really have an answer to your issues you raise

carlinmack commented 5 months ago

Besides from the regex issue this is now ready for review again, the identifier to quickstatement tool handles all the query strings you have mentioned