WEC-Sim / WEC-Sim

Wave Energy Converter Simulator (WEC-Sim), an open-source code for simulating wave energy converters.
https://wec-sim.github.io/WEC-Sim
Apache License 2.0
150 stars 165 forks source link

[BUG] Inconsistent motions with multiple waveClasses #1363

Closed mmacn42 closed 2 weeks ago

mmacn42 commented 2 weeks ago

Describe the bug I'm trying to use multiple waveClasses to simulate multi-spectral ocean conditions and seeing unrealistic WEC behaviors. To try and better understand, I ran this simple comparison between two test cases:

Test 1 WEC-Sim RM3 example model A single regularCIC wave, with height 2.0 meters and period 13 seconds

Test 2 WEC-Sim RM3 example model Four waveClasses, each with regularCIC waves and one quarter of the wave height of Test 1 (0.5 meters). Same period.

Workstation information (REQUIRED): Describe the workstation:

WEC-Sim file(s): I've uploaded the wecSimInputFile for each test case and the userDefinedFunctions I used to generate the plots I pasted below. The model I am running in this test case is the RM3 in the WEC-Sim examples folder.

multiwavetests.zip

How to reproduce: Running each of the two wecSimInputFiles should reproduce the models and plots I've included.

Expected behavior I expect the two models to have identical responses, as the superimposed waves are the same. However I see very different responses and forces on both bodies, shown below. I wonder if something is being double counted? Or if there is a mistake in my implementation please let me know.

Screenshots: The two tests produce identical wave elevations but different body motions and forces.

Wave elevations: image

Body motions: image image

Body forces: image image

MShabara commented 2 weeks ago

Hi @mmacn42,

The input files you attached are identical. Identical input files will produce identical results (assuming you used same .h5 and same .slx files).

I tested both input files you provided, using the geometry, hydroData, and .slx file from the examples folder. After running both input files, I found that they generated identical results. Unfortunately, I wasn’t able to replicate the issue you described.

Let me know if there’s anything specific you’d like me to check or if there are additional details that could help troubleshoot this further.

Best,

mmacn42 commented 2 weeks ago

Very sorry, I attached the wrong Test 2 file. Here is the correct one.

wecSimInputFile_test2.zip

MShabara commented 2 weeks ago

Hi @mmacn42

The current version of WEC-Sim does not define irregular waves by using multiple regular wave instances. While I understand that this approach can work in other software (such as OpenFOAM v11), it is not applicable in WEC-Sim. To define irregular waves, you'll need to use the specific options available in the WEC-Sim documentation for creating a single irregular wave instance.