CardsContainer should be responsive and look good on all screen sizes

WEEE-Open / skeeep

Jump to the best software for PoliTo students!

https://weee.link/skeeep

GNU General Public License v3.0

2 stars 2 forks source link

CardsContainer should be responsive and look good on all screen sizes #27

Closed e-caste closed 2 years ago

e-caste commented 2 years ago

Also test on mobile devices, both with the responsive design setting of Chrome/Firefox/Safari and by going with a physical phone to your local React development server (http://192.168.X.Y:3000)

Tested:

[x] Desktop Chrome
[x] Desktop Firefox
[ ] Desktop Safari
[ ] Mobile Chrome
[ ] Mobile Firefox
[x] Mobile Safari

e-caste commented 2 years ago

We can do this in two ways:

get the dimensions of the largest card (given its content) and apply them to all the other cards so they're all the same size
adjust the size of the cards individually based on their content (I think this is the default Bootstrap behavior)

hesam1993 commented 2 years ago

I used the percentage for the height of the cards, so in the large screens they all have the same size, and while on the smaller screens they have different heights.