WEEE-Open / tarallo

T.A.R.A.L.L.O. Inventory System
GNU Affero General Public License v3.0
16 stars 9 forks source link

Fix style, lint all the time #275

Closed Learath2 closed 1 year ago

Learath2 commented 1 year ago

After wrestling around with the weird action a bit, I decided to look into whether this optimization is even worth it. Linting the entire project takes seconds and github actions runners are free.

I removed the matrix runner on the CI: It didn't make much sense with composer.json requiring 7.1 (but faking 7.4?), Docker image using 8.0 to test on 8.1(latest) and 7.3

Is there a reason we keep the php version low? I don't quite know how you run production.

Also linted the entire project, phpcs doesn't do that well on modern js, I had to ignore one line to get it to work.