add DOMAIN_SEPARATOR public view function - Githubissues

WETH10 / WETH10

revamped contract

GNU General Public License v3.0

210 stars 114 forks source link

add DOMAIN_SEPARATOR public view function #90

Closed Ro5s closed 3 years ago

Ro5s commented 3 years ago

this PR makes DOMAIN_SEPARATOR a public view function per EIP-2612 by:

moving this variable from the permit() function into a new constructor()
adding DOMAIN_SEPARATOR() into IERC2612.sol
adding DOMAIN_SEPARATOR() into WETH10 .sol as:

bytes32 public override immutable DOMAIN_SEPARATOR;

this PR addresses this issue: https://github.com/WETH10/WETH10/issues/89

further, syntax and other formatting details have been reviewed and conformed to aide clarity.

Ro5s commented 3 years ago

great stuff. thank you everyone for reviewing and getting this PR closed quick!