WFCD / Warframe.NET

Under rewrite: Collection of Warframe libraries for C# developers.
MIT License
23 stars 8 forks source link

Date conversion failes #13

Closed jnccd closed 5 years ago

jnccd commented 5 years ago

This is a really cool project but when I try to run it I only get a "Unexpected character encountered while parsing value: {. Path 'Alerts[0].Activation', line 1, position 6576."

Which points to ""Activation":{"$date":{"$numberLong":"1543679128601"}}" in the json. So there is some error with the date conversion here or Im missing something.

Erlite commented 5 years ago

Hey! I'll check it out, but this project is currently under rewrite. You can check the rewrite branch for more details. The current implementation lacks a lot of things and is generally bad.

Erlite commented 5 years ago

@niklasCarstensen can you send the full stacktrace?

TobiTenno commented 5 years ago

@niklasCartensen you need to use api.warframestat.us not the base worldstate from DE

jnccd commented 5 years ago

Ohh I didn't expect DE to have multiple worldstate jsons Also thanks for answering so fast, I didn't expect that either. ^^

Im using your library here if you wanna look over it. I hope Im using the license correctly.

TobiTenno commented 5 years ago

They don't have multiple (apart from separate platforms), we maintain an alternate site with more readily useable values

TobiTenno commented 5 years ago

On the license on your other part, the attribution of the resource needs to be in either your readme or the application itself, and that banner should only be present if your project is listed in our banner project. We maintain a list of projects we support.

jnccd commented 5 years ago

The banner was still there from the fork but I removed it now and I also added the license to this project into the readme now

Erlite commented 5 years ago

Looks good, however, I do think that the copyright has to be included? I'm bad with licenses so don't quote me on this ^^'

TobiTenno commented 5 years ago

oh, i see now. you're writing an update for an existing C# app one of ours had made some time ago.

TobiTenno commented 5 years ago

If you just wanna write a PR on it, we can probably rope you in and let you just help maintain it