search

WFCD / Warframe.NET

Under rewrite: Collection of Warframe libraries for C# developers.
MIT License
22 stars 8 forks source link

Add Conclave, DailyDeal and Simaris models #15

Closed Khaoz-Topsy closed 5 years ago

Khaoz-Topsy commented 5 years ago

Just wanted to add a few models that were needed from #11 to make sure that you are happy with the way that I have done them, specifying the [JsonProperty("...")] on every property may be excessive... but I like the consistency😅.

I also tried to not use the properties mentioned in #12 (eta, startString, endString)

Erlite commented 5 years ago

Following consistency, it might be better to only specify the JSON token's name if it defers from the property's name, as seen in the models currently available. [JsonProperty] is enough if they don't defer, and is required for Newtonsoft.JSON as it cannot deserialize properties with private setters otherwise.

Khaoz-Topsy commented 5 years ago

Cool, fixed 😁

Erlite commented 5 years ago

Looks fine, thanks!