search

WFCD / warframe-hub

:blue_book: Warframe hub strives to be the community center of the Warframe game
https://hub.warframestat.us
Apache License 2.0
82 stars 28 forks source link

Collapse Invasions if more than 5, and add button to expand the rest #59

Closed TobiTenno closed 5 years ago

TobiTenno commented 6 years ago

Warframe Hub Issue

Summary (short): Hide invasions if there are more than 5

Description: This would save space and make sure users know there's more below. I don't know how we'd implement it, precisely, but it'd be fantastic

Mockups, screenshots, evidence:

(Check one)

Tithen-Firion commented 6 years ago

Just dropping bits of code that will help: $('#invasionList > li.list-group-item-borderless:nth-child(n+6)').slideToggle() (or slideUp and slideDown)

Of course you also need to show invasions that are hidden after one of 5 visible ones ends: $('#invasionList > li.list-group-item-borderless:nth-child(-n+5)').show()

TobiTenno commented 6 years ago

if you wanna make a quick pull just to see how it looks, i'll happily review it really quick and see how it looks. i'll add you to the org so it'll make a build for you

EricSihaoLin commented 5 years ago

I'm rethinking this, would a scrollable panel work? The only problem is, how would the user know it is a scrollable area?

dsinn commented 5 years ago

If the scrollbar is visible, it may be okay. Having a faded effect when you're not at the end of the content could also help, although I don't have the CSS savvy for the implementation details.

107g commented 5 years ago

Hello there,

I just digged up that issue. I'm trying to implement that feature by reusing the 'Collapsible' component used for Bounties.

TobiTenno commented 5 years ago

I look forward to seeing what you do with it

wfcd-bot-boi commented 3 years ago

:tada: This issue has been resolved in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: