WFCD / warframe-hub

:blue_book: Warframe hub strives to be the community center of the Warframe game
https://hub.warframestat.us
Apache License 2.0
83 stars 28 forks source link

:bug: synthesis is sometimes in the wrong language #771

Closed Oakmontowls closed 2 years ago

Oakmontowls commented 2 years ago

Summary

The page for synthesis targets is in the wrong language periodically. I have checked the language settings and they are set to english. Interestingly clearing the cache/cookies for the site does nothing, but opening the page in incognito mode does. image

Version

hub (Default)

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

Code of Conduct

TobiTenno commented 2 years ago

thanks for the report, it's likely part of the data caching on the api. I'll get it figured out at some point.

TobiTenno commented 2 years ago

Oh wait, incognito fixes it.... You might check your language settings, maybe?

Oakmontowls commented 2 years ago

I checked the language settings in warframe hub and they are set to English, is there another setting I should be looking at?

TobiTenno commented 2 years ago

I checked the language settings in warframe hub and they are set to English, is there another setting I should be looking at?

Nope, just that one.

TobiTenno commented 2 years ago

If you're familiar with doing so, and you wouldn't mind looking for calls to api.warframestat.us/synthTargets and checking the request language and response language headers, that'd be great, but it might be hit and miss.

Oakmontowls commented 2 years ago

I'm not sure how to do that but if you link me to a guide I can try

TobiTenno commented 2 years ago

For Request headers, as long as you get the "accept-language" header, that's primarily what i need. For Response headers, as long as you get "content-language", that's primarily what i need

Oakmontowls commented 2 years ago

image image It's currently in English but when I change the language to something else (Italian) It doesn't switch for the synthesis page and in the request headers it still has the same accept-language en-US with nothing about language in the response headers image image

Oakmontowls commented 2 years ago

Also the page is currently displaying in English

TobiTenno commented 2 years ago

ah, i'll definitely have to fix that. yeah, i'm guessing it's not really defaulting properly on the request & reply. i'll keep this open and work on it. thanks!

TobiTenno commented 2 years ago

yo! is it working properly more consistently now?

Oakmontowls commented 2 years ago

Well it's not loading at all for me right now.

TobiTenno commented 2 years ago

ah, i put in a fix for that as well, not sure why it's taking so long for updates to pull in on hub :hankey:

TobiTenno commented 2 years ago

please check it out now, you may need to do a hard refresh to get the updated content.

Oakmontowls commented 2 years ago

So it's working again but it isn't quite respecting the language option. In particular the names of the enemy is not getting translated when you change the language.

TobiTenno commented 2 years ago

i'll be honest, i think that's a shortcoming of the translation, not of hub. if you send me which language you're looking at, i'll check the data.

Oakmontowls commented 2 years ago

So just in just testing the languages "Italiano", "Čeština", and "Srpski" just default to English. As for the names not being translated, I noticed that the times the names were translated the image breaks like the entirety of the Chinese setting. image And then oddly other languages like Korean have a few translated names which also results in the broken images. image

TobiTenno commented 2 years ago

yes, i believe the chinese one incorrectly translated some image names. as for italian, czech and serbian, they are untranslated. if you're interested in translating for whichever language you need to leverage.

Oakmontowls commented 2 years ago

Yea none of those languages are ones I'd use I was just letting you know what is and isn't working.

TobiTenno commented 2 years ago

i have some fixes that should avoid the name causing bad images in a bit, but that'll be separate. thanks for looking and testing!

TobiTenno commented 2 years ago

fixed with a2259f78d6455275729e3e511f94ec6344225631