search

WFCD / warframe-items

📘 Get all Warframe items directly from Warframe's API. No more messy wikia scraping.
MIT License
279 stars 53 forks source link

Overrides dont work #113

Closed esunder closed 5 years ago

esunder commented 5 years ago

JavaScript utilizes pass-by-sharing for objects, not pass-by-reference: https://stackoverflow.com/a/38533677

This function does not modify the object that is passed into it https://github.com/WFCD/warframe-items/blob/development/build/parser.js#L727

An example of this is ExcaliburPrime is overridden to be tradeable: false in overrides.json, but it is still set to true in the Warframes.json https://github.com/WFCD/warframe-items/blob/development/data/json/Warframes.json#L9862

esunder commented 5 years ago

I found this while working on the Kubrow Collar. I can include a fix in that PR if wanted.

TobiTenno commented 5 years ago

i mean it works for everything else, lol

otherwise none of the other functions would work either

Not denying what you're seeing, just stating we've seen it work before.

Tested some options out, looks like we set result to be a const at some point, this being the breaking bit, since we're reassigning it in the overrides, so either setting each key manually or removing the const will solve the issue. i'll have a pr and we can talk about it on there, cause you're right, the data isn't getting set as expected.

nexus-ci commented 5 years ago

:tada: This issue has been resolved in version 1.544.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: