search

WFCD / warframe-items

📘 Get all Warframe items directly from Warframe's API. No more messy wikia scraping.
MIT License
281 stars 54 forks source link

Some items have `primeSellingPrice` but not `ducats` #124

Closed AlyoshaVasilieva closed 4 years ago

AlyoshaVasilieva commented 4 years ago

Describe the bug The relevant components for Ivara Prime, Aksomati Prime, and Baza Prime are missing ducats (edit: fixed in 5b04891e5c067cae86f38cb4301a38ed6ee7f8ca). However, all but the Blueprint do have primeSellingPrice, which appears to be ducats. primeSellingPrice appears to be present and a duplicate of ducats in a wide variety of items (311 items have primeSellingPrice, 378 have ducats).

Expected behavior All items with ducat value have ducats listed in exactly one field.

Versions:

AlyoshaVasilieva commented 4 years ago

Additionally: The ducats field is correct (100) for Valkyr Prime Systems, but primeSellingPrice is incorrect (45).

TobiTenno commented 4 years ago

Prime selling price is handed off from DE. We don't control accuracy of fields except where it's something we programmatically interpolate. (Ducats is from the wiki, so i can look at removing "primeSellingPrice" or overriding it so it matches the wiki value)

TobiTenno commented 4 years ago

I've updated this to rely on ducats, so ducats should always get set, and primeSellingPrice will remain, but could be removed at some point.