WFCD / warframe-items

📘 Get all Warframe items directly from Warframe's API. No more messy wikia scraping.
MIT License
279 stars 53 forks source link

:bug: Valkyr Prime Systems BP has wrong ducat value #149

Closed dimon222 closed 4 years ago

dimon222 commented 4 years ago

Describe the bug This is what All.json shows: image

This is what official api has: image

This is what wiki has: image

Somehow we still end up with 45, how happen?

tezf commented 4 years ago

This is interesting. By DE's conventions, Valk's systems should have had it's ducat value decreased from 100 to 65 when it was released as an uncommon drop in Axi V9. But the wiki and in game both shows 100 ducat. Might be an oversight from DE's perspective, but no insight into how this becomes 45 instead.

TobiTenno commented 4 years ago

sorry it's been a bit, doing some testing on it right now to see where the value is precisely coming from. what's likely happening is....

addDucats (item, ducats) {
    if (!item.name.includes('Prime') || !item.components) return
    for (const component of item.components) {
      if (component.primeSellingPrice) component.ducats = component.primeSellingPrice

      if (!component.tradable || component.ducats) continue
      const composite = `${item.name} ${component.name}`;
      const wikiaItem = ducats.find(d => d.name.includes(`${item.name} ${component.name}`))
      if (wikiaItem) {
        component.ducats = wikiaItem.ducats
      } else {
        warnings.missingDucats.push(`${item.name} ${component.name}`)
      }
    }
  }

up on the continue line, it's likely getting a bad value from DE's data

F3l1XQu1ll commented 4 years ago

Can you tell me the link to DEs raw data? I remember some kind of mirror side for it.

dapal-003 commented 4 years ago

The android manifests indicate that it should be 100 ducats the root is http://content.warframe.com/PublicExport/Manifest/ and I believe the data is inside of the recipes one, so http://content.warframe.com/PublicExport/Manifest/ExportRecipes_en.json!00_qm4uJUgGX7fgua4iBBrmXw

TobiTenno commented 4 years ago

i can point you to how we grab it, but it's a multi-step process.

Grab this url: http://content.warframe.com/PublicExport/index_en.txt.lzma

Then unzip it, open up the file and download the applicable file from this format: http://content.warframe.com/PublicExport/Manifest/${endpoint}

TobiTenno commented 4 years ago

Yeah, I'm gonna let it just always fall into the wikiItem.ducats instead of only falling back if there's no value, just getting those changes in and tested

TobiTenno commented 4 years ago

looking correct on the repo now, i'll go ahead and close this