Merge with warfarme-wikia-scrapers

WFCD / warframe-items

📘 Get all Warframe items directly from Warframe's API. No more messy wikia scraping.

MIT License

279 stars 53 forks source link

Merge with warfarme-wikia-scrapers #28

Closed Kaptard closed 6 years ago

Kaptard commented 6 years ago

While we got a very solid basis from the API data, the wikia still has some more data that we should include, so I'd suggest merging warframe-wikia-scrapers with this repo.

Some things I can think of off the top of my head:

[x] Damage distribution (Slash, Puncture, Impact, Elemental)
[x] Conclave
[x] Sprint Speed
[ ] Vaulted state
[x] Introduced
[x] Market cost through platinum
[x] Use "Class" key value for weapon types instead of vaguely guessing.
[x] Disposition
[x] Use "traits" key for "tags"

Feel free to edit this comment to add more.

TobiTenno commented 6 years ago

This complicates the update of warframe-status (which depends on up-to-date data) when serving the warframe and weapons data...

Do you have any plan as to how you'd want to do that?

Kaptard commented 6 years ago

I'm not familiar with how warframe-status is set up - so how would the data changes make things more complicated?

I was thinking that we could just fetch wikia data before getting the API data and then apply additional stuff from the wikia when looping through each item.

TobiTenno commented 6 years ago

Right now, when warframe-wikia-scrapers updates, it releases a new version of warframe-worldstate-data and updates warframe-status, trigging a new deployment on heroku.