Closed mdpung closed 11 months ago
Primaries aren't melee. Why would Deconstructor be in primaries?
SentinelWeapons is driven off the DE-provided field of ProductCategory to make them easy to find. I'm not gonna break them up further because of your preferences
Primaries aren't melee. Why would Deconstructor be in primaries?
That's what your data model currently classifies it as. The Deconstructor currently has the category of "Primary" in the dataset, so that should be a question for the devs.
SentinelWeapons is driven off the DE-provided field of ProductCategory to make them easy to find. I'm not gonna break them up further because of your preferences
I understand that and I'm not asking you to change the product categories. I'm pointing out that the way weapons, categories, and classifications are structured in the dataset are inconsistent and unintuitive making it difficult to use. I, as a developer, am just providing feedback on my experience trying to use it. I assume the whole purpose of this api/library is to make it accessible for other developers, so I figured there would be openness to improve it.
I'm literally "the devs" of this project. if you feel like waiting on DE, feel free to go find them.
I'm literally "the devs" of this project. if you feel like waiting on DE, feel free to go find them.
Yet you ask
Why would Deconstructor be in primaries?
You are the one who set Deconstructor to be in primaries. That was not a proposed state for the data. That is the current state.
**Please note this is just my observation and feedback based on my experience with using this data set, and meant for food for thought.**
Is your enhancement request related to a problem? Please describe. I noticed inconsistencies in the way weapons are classified in their respective custom categories. Let's compare three weapons for example: A weapon like
Soma
hasA weapon like
Deconstructor
hasA weapon like
Corvas
hasYet the three belong to the respective categories:
When I realized that the
Deconstructor
was not in thePrimary.json
it took me a while to realize this discrepancy.Another discrepancy I noticed is that Archwing and Tenno have their separate categories for their types of weapons. Ex:
Tenno:
Primary.json
andMelee.json
Archwing:Arch-Gun
andArch-Melee
Sentinel:SentinelWeapons
Describe the upgrade you'd like I can understand the more specific sub categories for the robotics and the archwings, so I would like to suggest a few options.
Primary.json
to something not so broad so it doesn't umbrella theSentinelWeapon
andArch-Gun
exceptions, such asTennoPrimary
. In addition, you could havePrimaries.json
encompass all the weapons that actually have the category asPrimary
.As for the second discrepancy, may I suggest:
SentinelWeapons
intoSentinelPrimary
andSentinelMelee
Describe alternatives you've considered N/A
Additional context N/A