search

WFCD / warframe-items

📘 Get all Warframe items directly from Warframe's API. No more messy wikia scraping.
MIT License
281 stars 54 forks source link

[Bug] Some `uniqueName`s don't match up with i18n entries #617

Open Cypheriel opened 2 months ago

Cypheriel commented 2 months ago

Describe the bug

Item's such as /Lotus/Types/Recipes/Weapons/WeaponParts/PrimeWyrmCerebrum are missing i18n entries in i18n.json

NodeJS Version

N/A

npm Version

N/A

warframe-items Version

N/A

Access Method

npm Package (Default)

What happened?

When looking at the components of Wyrm Prime, you are given /Lotus/Types/Recipes/Weapons/WeaponParts/PrimeWyrmCerebrum for its cerebrum. However, when looking that uniqueName up in i18n.json, there are zero matches. It does seem that the Public Export provides the correct value under /Lotus/Language/Menu/CraftingComponent_PrimeWyrmCerebrum: "Wyrm Prime Cerebrum". It's worth mentioning that I gathered this information from an unrelated project, however I hope it provides some insight into the issue.

Side note: It would seem that the names for components in general tend to be... too vague. For example, "Cerebrum" as a component name is close to unusable when it comes to internationalization. In this case, it should be "Wyrm Prime Cerebrum", as it would be in-game.

TobiTenno commented 2 months ago

yeah, the problem is you're comparing a language entry for the interface (/Lotus/Language/Menu/CraftingComponent_PrimeWyrmCerebrum) with a component item (/Lotus/Types/Recipes/Weapons/WeaponParts/PrimeWyrmCerebrum). We have no way to mesh these values.

re: "generic" component names, that's on purpose to allow better image coalescing with common component images so we don't accidentally generate thousands of duplicate images.

There's not really anything for us to do here, as they aren't programmatically related (like one of the names isn't combined in the other) apart from the final part of the component item being appended to /Lotus/Language/Menu/CraftingComponent_, which we can't really confirm is universally true to mesh up.

TobiTenno commented 2 months ago

i'll try it out, but definitely reclassing this as an enhancement request