WFCD / warframe-items

📘 Get all Warframe items directly from Warframe's API. No more messy wikia scraping.
MIT License
277 stars 53 forks source link

[Bug] Some cdn.warframestat.us/img links are broken #652

Open fburaktrd opened 2 days ago

fburaktrd commented 2 days ago

Describe the bug

Some cdn.warframestat.us/img links are broken

NodeJS Version

v20.4.0

npm Version

v9.7.2

warframe-items Version

v1.1263.9

Access Method

npm Package (Default)

What happened?

Hi again!

Some cdn.warframestat.us/img links are broken. I could not determine how many paths are broken, but here are the ones I can find so far

image image

TobiTenno commented 1 day ago

where are you using this from? are you referencing them directly or pulling the imageName off of the item? if you look at my recent update on https://github.com/wfcd/warframe-hub for steel-essence, that's the kind of lookup you'd be wanting to use.

Also, you specified that you're using npm package, but you're referencing the image url, but don't specify how you got the imageName. please let us know.

fburaktrd commented 1 day ago

Hi Tobi,

Sorry for the lack of information. I actually referenced the imageName property in the item object from the warframe-items package. Then I followed the documentation and constructed my url as https://cdn.warframestat.us/img/${imageName}.

I checked your commit there and saw that you used the https://api.warframestat.us/items/search url to retrieve the image names.

Here is the image name in the response from https://api.warframestat.us/items/search image

But it is only rubedo.png in warframe-items package. If I'm not missing anything, I'd be very happy if you could update those imageNames

Also, I liked the way you adjust the images according to url parameters. I think you should definitely mention that in the doc!

TobiTenno commented 1 day ago

The API is powered by the node module, so it might be a matter of how you're fetching it from the package or how we're storing it on a particular item.

Could you share a snippet of how you're using the package to get the itemName and we could see if there's something weird about the item that you're getting back that we could update?

SlayerOrnstein commented 23 hours ago

@fburaktrd looks like you're using an older version of warframe-items, before #635 was introduced