search

WFP-VAM / prism-app

PRISM is an interactive map-based dashboard that simplifies the integration of geospatial data on hazards, along with information on socioeconomic vulnerability
MIT License
49 stars 34 forks source link

[Tech Debt]: Create cassettes for external API calls in pytest #1348

Open gislawill opened 1 month ago

gislawill commented 1 month ago

Provide a clear and concise description of what you want to happen.

PR #1328 adds pytest-recordings to our API tests which stores external API responses within "cassettes" in the codebase. These cassettes can then be used by other developers and in CI to create a more stable test environment (with the added benefits of not needing to share API keys).

We should apply these cassettes to more services as soon as PR #1328 is merged.

Is there anything else you can add about the proposal? You might want to link to related issues here, if you haven't already.

This is relevant to the problem we're in addressing in https://github.com/WFP-VAM/prism-app/pull/1346

gislawill commented 1 month ago

Heads up @wadhwamatic and @ericboucher, I've created this ticket to address after the Google Floods work is merged. Please let me know if you have any thoughts

wadhwamatic commented 1 month ago

I don't really know what this means tbh so leave it to @ericboucher to give his feedback