search

WFoundation / WF.Player.WinPhone

WF.Player implementation for Windows Phone.
5 stars 1 forks source link

UI: Fix non-latin characters appearing as garbage. #4

Closed Mangatome closed 10 years ago

Mangatome commented 10 years ago

See it live at:

http://forums.groundspeak.com/GC/index.php?showtopic=315741&view=findpost&p=5344017

Mangatome commented 10 years ago
charlenni commented 10 years ago

Brice, you could not solve this last problem. The ? are in the cartridge description. You could see them with a hex editor.

Mit freundlichen Grüßen Dirk Weltz

Am 02.02.2014 um 13:05 schrieb Mangatome notifications@github.com:

In-game broken text fixed in 1.0.2. Startup description text filled with '?' still not fixed. — Reply to this email directly or view it on GitHub.

Mangatome commented 10 years ago

Yes, but the description appears in the byte code as a field of Cartridge, and it is encoded in UTF-8. My intention is to load this field and display it instead of the GWC's field, if available. If this fails I'd at least want to signal to the user that the display is broken because of the cartridge, not the app.

charlenni commented 10 years ago

Wasted time. Description of the cartridge is in a Lua long string. They aren't capable of holding special characters. Even if, they don't go trought the Wherigo compiler. So no existing cartridge have Special characters in this field.

Mit freundlichen Grüßen Dirk Weltz

Am 02.02.2014 um 13:18 schrieb Mangatome notifications@github.com:

Yes, but they appear in the byte code as a field of Cartridge, and they are encoded in UTF-8. My intention is to load this field and display it instead of the GWC's field, if available. If this fails I'd at least want to signal to the user that the display is broken because of the cartridge, not the app.

— Reply to this email directly or view it on GitHub.

Mangatome commented 10 years ago

The following Finnish cartridge does: http://www.wherigo.com/cartridge/details.aspx?CGUID=3e805eeb-a06d-4a46-9b76-6670c37f500a

(check the bytecode for Description)

charlenni commented 10 years ago

Ok, that's correct, the owner used UTF-8 in Description, but the compiler replaced it by ?.

Again, I don't think it is worth the effort. There are, lets say, 5 cartridges, which using this. For this, you would start each cartridge in a own environment to get the Description.

Viele Grüße und weiterhin viel Spaß Dirk (Charlenni)

Am 02.02.2014 13:43, schrieb Mangatome:

The following Finnish cartridge does: http://www.wherigo.com/cartridge/details.aspx?CGUID=3e805eeb-a06d-4a46-9b76-6670c37f500a

(check the bytecode for Description)

— Reply to this email directly or view it on GitHub https://github.com/WFoundation/WF.Player.WinPhone/issues/4#issuecomment-33899447.

Mangatome commented 10 years ago

Well it is problematic, because the Title of the cartridge itself may be containing garbage characters. It is UI breaking. (Cf http://forums.groundspeak.com/GC/index.php?showtopic=315741&view=findpost&p=5344017)

One way to solve it would be to indeed selectively run the cartridges which are affected in their own environment and import the text.

charlenni commented 10 years ago

I don't think, that the other players could display this. They use the description in the GWC header. So I think, that never someone saw this correct description. It is only visible at the cartridge page.

Viele Grüße und weiterhin viel Spaß Dirk (Charlenni)

Am 02.02.2014 17:17, schrieb Mangatome:

Well it is problematic, because the Title of the cartridge itself may be containing garbage characters. It is UI breaking. (Cf http://forums.groundspeak.com/GC/index.php?showtopic=315741&view=findpost&p=5344017)

One way to solve it would be to indeed selectively run the cartridges which are affected in their own environment and import the text.

— Reply to this email directly or view it on GitHub https://github.com/WFoundation/WF.Player.WinPhone/issues/4#issuecomment-33904196.