search

WGBH-MLA / mlavalon

Apache License 2.0
0 stars 0 forks source link

Remove AdminData#needs_update and AdminData#last_updated #159

Closed afred closed 4 years ago

afred commented 4 years ago

Because

  1. AdminData#last_updated is not being used. It gets populated in an actor that is not part of the actor stack, and no record on AMS currently has a value for it. Same with AdminData#needs_update
  2. The function of AdminData#last_updated is almost identical to AdminData#updated_at

Possible Solution

  1. Remove the needs_update and last_updated fields from admin_data table.
  2. Create AdminData#needs_update? method that returns true if AdminData#last_pushed date comes before the system_updated_dtsi of the Assets's Solr record, or any of the Asset's childrens' solr records.

Done when

  1. admin_data.last_updated and admin_data.needs_update fields are removed from DB schema.
  2. All code made obsolete by the removal of those two fields is also removed.
  3. AdminData#needs_update? method is added and accurately returns true if the Asset, or any of it's children, has been updated since the the date stored in AdminData#last_pushed
afred commented 4 years ago

wrong repositor.. moving to AMS