It all started long ago, when we were having trouble with video playback across browsers.
IIRC, Firefox did not like our .mp4 files.
Our solution was to create .webm files and put them in S3 alongside the .mp4 files.
Then, when we're rending <video> elements, we'd put both URLs in as <source ...> elements, where if one was missing, it would just gracefully fall back to the other.
At some point (maybe from the beginning of this change) PBCore#proxy_srcs was set to just return both URLs.
Buuuuut.......... we didn't fix the logic in ValidatedPBCore#url_validate, which tries to ensure that all URLs exist in S3.
So the logic that handles ValidatedPBCore#proxy_srcs is fundamentally different when rendering vs. when validating: in the former, you only need 1 of the URLs to work; in the latter you need all of the URLs to work.
The ingester performs some validation that checks the PBCore model's "url methods" for external URL, and then performs a HEAD request to make sure those files are available.
But... for videos, the URLs it's checking have both a .webmand.mp4 file extension (in that order).
Thus... when the validator tries to HEAD the URL with the .webm file extension, it fails because only the .mp4 file exists.
Solution
There's so much opportunity for re-factoring here (like replacing the whole PBCore model layer)... but.... a short-term fix probably looks something like making the distinction in ValidatedPBCore#url_validate between URLs that all must be present, and URLs for which any can be present.
Done when
Ingest does not fail for video records having only a .mp4 file in S3
Background
It all started long ago, when we were having trouble with video playback across browsers.
IIRC, Firefox did not like our
.mp4files.Our solution was to create
.webmfiles and put them in S3 alongside the.mp4files.Then, when we're rending
<video>elements, we'd put both URLs in as<source ...>elements, where if one was missing, it would just gracefully fall back to the other.At some point (maybe from the beginning of this change)
PBCore#proxy_srcswas set to just return both URLs.Buuuuut.......... we didn't fix the logic in
ValidatedPBCore#url_validate, which tries to ensure that all URLs exist in S3.So the logic that handles
ValidatedPBCore#proxy_srcsis fundamentally different when rendering vs. when validating: in the former, you only need 1 of the URLs to work; in the latter you need all of the URLs to work.The ingester performs some validation that checks the PBCore model's "url methods" for external URL, and then performs a HEAD request to make sure those files are available.
But... for videos, the URLs it's checking have both a
.webmand.mp4file extension (in that order).Thus... when the validator tries to HEAD the URL with the
.webmfile extension, it fails because only the.mp4file exists.Solution
There's so much opportunity for re-factoring here (like replacing the whole PBCore model layer)... but.... a short-term fix probably looks something like making the distinction in
ValidatedPBCore#url_validatebetween URLs that all must be present, and URLs for which any can be present.Done when
Ingest does not fail for video records having only a .mp4 file in S3