search

WGBH-MLA / ov-frontend

Open Vault Frontend
https://wgbh-mla.github.io/ov-deploy
0 stars 0 forks source link

🎈 Elasticsearch #34

Closed mrharpo closed 1 month ago

mrharpo commented 8 months ago

Elasticsearch

Basic elasticssearch component. Includes

Closes wgbh-mla/ov-wag#122

## Done
- [x] Link result title to page
- [x] Increase pagination size: 10
- [x] Results per page selector
- [x] Debounce input, 200-300ms
- [x] Pagination numbers should be horizontal
- [x] Integrate series search?
- [x] Fix dev server search results
- [x] No Results component
- [x] Move series to top 
## Todo
- [x] Better Series result styles: show all series links together?
- [x] Better results layout styling
- [x] Sync URL with UI
- [x] Label Hit results: Exhibit vs Collection
- [x] Fix AAPBResults component
- [x] Change wording on AAPBResults
- [x] Bigger search bar
- [x] Rearrange Nav bar: Scholar Exhibits, Special Collections, GBH Series, About, Search
- [x] Fix `NoResult` organization
- [x] Highlight Series title matches
### Search Requests from June 28 Demo
- [x] Add title areas to more obviously define Series results and Scholar Exhibit results
- [x] Display GBH Series results below Scholar Exhibits and Special Collections
- [x] Instead of pagination for GBH series in search results, have a -> to click and a rotating carousel
- [x] Shorten the size of the Special Collection and Exhibit result tiles
- [x] Put all stickers at the bottom of the tile and make smaller, 
- [x] Try different colors to differentiate between Special collections and Exhibits
- [x] Make the result tile title more prominent (bigger, bolder?)
- [x] Make whole tiles clickable
- [x] Move number of results per page dropdown to appear after SC/Exhibit results
## Optional
- [ ] Change highlight color to represent relevance
gitguardian[bot] commented 7 months ago

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [9607557](https://dashboard.gitguardian.com/workspace/100270/incidents/9607557?occurrence=142991736) | Triggered | Generic High Entropy Secret | ef8bc8c475c76aea35d86f60d4d906562684c12f | app/classes/search-ui.jsx | [View secret](https://github.com/WGBH-MLA/ov-frontend/commit/ef8bc8c475c76aea35d86f60d4d906562684c12f#diff-325361923412cc9e8adb46e15b931f33b56a67b20507a618e5eaa360da126e58R36) | | [9607557](https://dashboard.gitguardian.com/workspace/100270/incidents/9607557?occurrence=125057318) | Triggered | Generic High Entropy Secret | 124c74736f3477f1a3bf79bae51ae57757d9a870 | search/search-ui.jsx | [View secret](https://github.com/WGBH-MLA/ov-frontend/commit/124c74736f3477f1a3bf79bae51ae57757d9a870#diff-146db74df0254531b9d3c5316e3555ab2015d3cd51ca66d1dc5bd7214a6f86bbR18) | | [9607557](https://dashboard.gitguardian.com/workspace/100270/incidents/9607557?occurrence=160546471) | Triggered | Generic High Entropy Secret | e7875df9d9cc25b89372841edcb38a49c8deff83 | app/data/searchkit.json | [View secret](https://github.com/WGBH-MLA/ov-frontend/commit/e7875df9d9cc25b89372841edcb38a49c8deff83#diff-5ec2d881c3c11f2fd3e5242008f328266c36126e8c29c4c0654e51fd043b3454R4) | | [9607557](https://dashboard.gitguardian.com/workspace/100270/incidents/9607557?occurrence=160546472) | Triggered | Generic High Entropy Secret | e7875df9d9cc25b89372841edcb38a49c8deff83 | app/classes/search-ui.tsx | [View secret](https://github.com/WGBH-MLA/ov-frontend/commit/e7875df9d9cc25b89372841edcb38a49c8deff83#diff-568df9e980eb75d892c4d29eff9b28a689367f8af23f5526e2655be6c51d1320L52) | | [9607557](https://dashboard.gitguardian.com/workspace/100270/incidents/9607557?occurrence=145846657) | Triggered | Generic High Entropy Secret | cb4ebd716975ef1a2f3e173f5198679ae94b22b5 | app/classes/search-ui.tsx | [View secret](https://github.com/WGBH-MLA/ov-frontend/commit/cb4ebd716975ef1a2f3e173f5198679ae94b22b5#diff-568df9e980eb75d892c4d29eff9b28a689367f8af23f5526e2655be6c51d1320R45) | | [9607557](https://dashboard.gitguardian.com/workspace/100270/incidents/9607557?occurrence=145846658) | Triggered | Generic High Entropy Secret | cb4ebd716975ef1a2f3e173f5198679ae94b22b5 | app/classes/search-ui.jsx | [View secret](https://github.com/WGBH-MLA/ov-frontend/commit/cb4ebd716975ef1a2f3e173f5198679ae94b22b5#diff-325361923412cc9e8adb46e15b931f33b56a67b20507a618e5eaa360da126e58L36) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.