search

WGBH-MLA / ov-frontend

Open Vault Frontend
https://wgbh-mla.github.io/ov-deploy
0 stars 0 forks source link

Carousel Changes Height When Images Are Different Heights #60

Closed foglabs closed 2 weeks ago

foglabs commented 2 months ago

Description

The homepage carousel changes height with the height of each slide image, but we want the carousel to remain a consistent height for every slide in order to preserve the page layout regardless of the slide content.

Done when the carousel maintains a consistent height for any image dimensions.

Reproduction steps

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

No response

Screenshots

![DESCRIPTION](LINK.png)

Browsers

No response

OS

No response

Additional context

No response

foglabs commented 3 weeks ago

tested this out, wagtail's image cropping is working as we desired. image renditions are produced with a 1600/500 aspect ratio regardless of the size of the input image. the height difference we're now seeing between images seems to be caused by rounding discrepancies for different sizes of images.