WGLab / PhenCards

Development of phencards.org web server for one stop shop of phenotype information
5 stars 1 forks source link

name 'flash' is not defined #121

Closed kaichop closed 1 year ago

kaichop commented 1 year ago

The new Docker image shows "name 'flash' is not defined" error when searching clinical notes. @jimhavrilla is there a typo for "flask"?

image

jimhavrilla commented 1 year ago

no, it should be: from flask import session, request, Response, abort, flash flash is an import from flask. it allows one to flash an error message. https://flask.palletsprojects.com/en/2.2.x/patterns/flashing/#:~:text=Flask%20provides%20a%20really%20simple,layout%20template%20that%20does%20this .

On Thu, Mar 23, 2023 at 10:19 PM Kai Wang @.***> wrote:

The new Docker image shows "name 'flash' is not defined" error when searching clinical notes. @jimhavrilla https://github.com/jimhavrilla is there a typo for "flask"?

[image: image] https://user-images.githubusercontent.com/5926328/227407542-aaee7fe9-d45c-406d-9a51-201fa4086802.png

— Reply to this email directly, view it on GitHub https://github.com/WGLab/PhenCards/issues/121, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSDYBEZGSJJBF2LT22QRT3W5UACTANCNFSM6AAAAAAWF7N2HQ . You are receiving this because you were mentioned.Message ID: @.***>

kaichop commented 1 year ago

okay, it is still the same docker instance that I did not change, can you check why flash is not imported now?

image

jimhavrilla commented 1 year ago

The site is working for me On Thu, Mar 23, 2023 at 10:48 PM Kai Wang @.***> wrote:

okay, it is still the same docker instance that I did not change, can you check why flash is not imported now?

[image: image] https://user-images.githubusercontent.com/5926328/227411456-9a191011-c6ca-4c9b-8278-ebfd8c56784a.png

— Reply to this email directly, view it on GitHub https://github.com/WGLab/PhenCards/issues/121#issuecomment-1482175812, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSDYBC4NQUQP5LMO4B2R2DW5UDO5ANCNFSM6AAAAAAWF7N2HQ . You are receiving this because you were mentioned.Message ID: @.***>

kaichop commented 1 year ago

I tried two browsers now and both show same message. Did you check the "patients notes" tab? I can use the "phenotype search" tab just fine.

jimhavrilla commented 1 year ago

I see. I don't know why it bugged out before (I just did git checkout queries.py and rebuilt it) but it is now fixed in prod. [image: image.png]

On Thu, Mar 23, 2023 at 10:53 PM Kai Wang @.***> wrote:

I tried two browsers now and both show same message. Did you check the "patients notes" tab? I can use the "phenotype search" tab just fine.

— Reply to this email directly, view it on GitHub https://github.com/WGLab/PhenCards/issues/121#issuecomment-1482178367, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSDYBEAO3JV232V2KWNDDLW5UEBPANCNFSM6AAAAAAWF7N2HQ . You are receiving this because you were mentioned.Message ID: @.***>

jimhavrilla commented 1 year ago

I will PR the feature change to master. PR #122

Message ID: @.***>

kaichop commented 1 year ago

Okay thank you!

jimhavrilla commented 1 year ago

Sure

On Thu, Mar 23, 2023 at 11:11 PM Kai Wang @.***> wrote:

Okay thank you!

— Reply to this email directly, view it on GitHub https://github.com/WGLab/PhenCards/issues/121#issuecomment-1482190110, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSDYBBDZUGUOIZU2XSHW3LW5UGHPANCNFSM6AAAAAAWF7N2HQ . You are receiving this because you were mentioned.Message ID: @.***>