Follow image_transport conventions - Githubissues

WHOIGit / PhytO-ARM

PhytO-ARM: Phytoplankton Observing for Automated Real-time Management

https://hablab.whoi.edu/phyto-arm/

GNU General Public License v3.0

0 stars 0 forks source link

Follow image_transport conventions #28

Open rgov opened 1 year ago

rgov commented 1 year ago

[ ] Update topic names in IFCB node to publish compressed images as /ifcb/image/compressed and /ifcb/roi/image/compressed respectively.

[ ] Delete the custom image_transport_node and replace it with:

<node pkg="image_transport" type="republish" name="image_republisher" args="compressed raw">
    <remap from="in" to="/ifcb/roi/image" />
    <remap from="out" to="/ifcb/roi/image" />
</node>

[ ] Declare appropriate dependency on image_transport in package.xml.
[ ] Maybe update the rosbag exclusions pattern from /ifcb/image to /ifcb/image(/.*)?
[ ] Maybe remap topics at the rosbridge node such that /ifcb/roi/image is remapped to /ifcb/roi/image/do_not_use. (The rtsp_camera remapping should probably also be done at the rosbridge node level.)