search

WHOIGit / ifcbdb

IFCB dashboard
MIT License
8 stars 9 forks source link

change default for include_coordinates on api_bin to "false" #363

Closed joefutrelle closed 1 year ago

joefutrelle commented 1 year ago

the default behavior (which the UI might be using instead of explicitly setting include_coordinates to "true", so a mod would be needed there as well) causes a mosaic generation backlog when scripts are calling /api/bin.

https://github.com/WHOIGit/ifcbdb/blob/dfe8798eaf1a5bc87e526089426c8650849b2a8f/ifcbdb/dashboard/views.py#L920

joefutrelle commented 1 year ago

@mike-kaimika any UI call to /api/bin from the GUI that is relying on the default of "true" will need to be changed so that it explicitly sets include_coordinates to "true".

Quick glance shows just a few places where the change will be needed.

https://github.com/WHOIGit/ifcbdb/search?q=%2Fapi%2Fbin

joefutrelle commented 1 year ago

there appear to be knock-on effects of making the above changes that break navigation ("next"/"previous")

mike-kaimika commented 1 year ago

@joefutrelle Here's the PR with the changes: https://github.com/WHOIGit/ifcbdb/pull/364