search

WHOIGit / ifcbdb

IFCB dashboard
MIT License
6 stars 7 forks source link

Don't parse returned image coordinates from string #379

Closed srstsavage closed 1 year ago

srstsavage commented 1 year ago

Image coordinates appear to already be parsed here, and treating them as a string results in errors.

Not sure what is causing this difference, but I had to fix to get image mosaics working on a recent deployment.

mike-kaimika commented 1 year ago

@srstsavage Do you have the original error you were receiving? I ran through this locally, and the output from that backend call is returning a string of JSON (and not parsed JSON): image

That data is coming from a call to coordinates_to_json, which is using to_json on a dataframe: "Convert the object to a JSON string."

What version of Pandas are you using - its possible I'm on an older version and they change how that function works. Additionally, which browser are you using, in case that's playing some role in the situation

srstsavage commented 1 year ago

I’m on leave for a few days, will check it out when I return. I’m guessing it’s a pandas version thing as well.

joefutrelle commented 1 year ago

Here's the Pandas call to to_json which sets orient to records

I don't see a change note in the Pandas doc for to_json that would indicate some change in 2.0, but I don't think that's enough to rule out Pandas version as the possible culprit, because subtleties abound.

srstsavage commented 1 year ago

Yeah, I'm not sure what happened but I'm no longer seeing the original issue. Going to close this for now, can revisit if a future pandas upgrade or other change causes it to happen again. Thanks.