WHOIGit / nes-lter-ims

NES-LTER information system components
MIT License
5 stars 0 forks source link

chlorophyll API output NA when no matching bottle metadata #36

Open sbeaulieu opened 3 years ago

sbeaulieu commented 3 years ago

Output NA when no matching bottle metadata [API also will not output bucket samples bc no bottle summary.]

ecrockford commented 3 years ago

Assuming MVCO data eventually makes it into the API, this will be an issue because there's a significant number of bucket samples. MVCO will probably have a different approach for the API anyways but just wanted to point it out.

Also, heaven forbid we have a cruise with a broken CTD but we could encounter a cruise with numerous bucket samples where this could present a problem.

sbeaulieu commented 2 years ago

I think similar issue for nutrient data product when lack of CTD bottle btl file, e.g., AR24A missing Casts 1 & 2, AR28B missing Cast 1

ecrockford commented 1 year ago

AR24A Cast 2 in chl doc actually should have been Cast 3. Fixed in NESLTERchl.xlsx today (2/11/2023). Scanned sosik log sheets have incorrect record of Cast 2 but CTD log sheet corrects to Cast 3 and CTD btl file for C3 matches log sheet depths.

sbeaulieu commented 1 year ago

Kate confirm bucket samples retained in current product thanks