search

WHOIGit / photic

Image annotation tool
MIT License
2 stars 0 forks source link

eliminate need to shift-refresh javascript upon new release #184

Open joefutrelle opened 3 years ago

mike-kaimika commented 2 years ago

@joefutrelle The two options we have are:

  1. Always include a ? at the end of the include for the js file. However, this will prevent ANY caching of the file, not just per release
  2. Same as above, but use a version number instead of a timestamp. E.g., abc.js?v=2.1

1 has the benefit of not being "forgotten" in a new release. #2 is less thrashing, since it will still allow the browser to cache, but we have to update the version number, on each "release". Right now, I don't believe we actually have true releases, and its just when a new version is deployed to the server, correct? If that's the case, maybe we should work on formalizing the release process first, and then tackle this one right after (which would then be super quick to change)

joefutrelle commented 2 years ago

Option 1 for now. Will we need to do this for dependencies as well or just our JS? I think the former.

mike-kaimika commented 2 years ago

Updated Files https://github.com/WHOIGit/photic/pull/223