Typo in kwargs in print_convergencehistory

WIAS-PDELib / ExtendableFEM.jl

High Level API Finite Element Methods based on ExtendableGrids and ExtendableFEMBase

MIT License

4 stars 7 forks source link

Typo in kwargs in print_convergencehistory #17

Open jpthiele opened 3 hours ago

jpthiele commented 3 hours ago

The keyword argument seperated should be separated. I am not sure how much this is used and I can look into ways to deprecate such an argument.

Since we are still on 0.x we could also 'simply' rename this and hope no-one is using it so far.

j-fu commented 2 hours ago

Just as a remark: at this point, Julia extends the notion of semver: Julia Pkg considers a change from 0.n to 0.n+1 as breaking.

BTW that is why I nowadays think that makes sense to move to versions 1.x as early as possible.

chmerdon commented 2 hours ago

I think nobody else is using this particular function, so I would not mind to simply rename it at this stage.

Before releasing 1.0 I think we should think about refactoring some bulky parts of the code like the FEEvaluator as @jpthiele and @pjaap already suggested earlier.