WIAS-PDELib / ExtendableGrids.jl

MIT License
21 stars 11 forks source link

better fix for negative cell volumes in tensor grid simplexgrid constructor #14

Open chmerdon opened 2 years ago

chmerdon commented 2 years ago

It was observed that the old tensor grid simplexgrid constructor can lead to meshes with negative cell volumes which can confuse solvers and CellFinder. The current quick fix (https://github.com/j-fu/ExtendableGrids.jl/commit/f9d47ae0d297d379a7e1838727f6ad303e390274) corrects this by instantiating CellVolumes and permuting the first two nodes in the those cells that have a negative volume. Can we find a better solution by creating a proper cells3 field in simplexgrid.jl:553 immediately (such that also the bfacenodes are properly set)?

j-fu commented 2 years ago

Ok, I'll register this, but let us keep this open...