search

WICG / EventListenerOptions

An extension to the DOM event pattern to allow authors to disable support for preventDefault
Other
1.17k stars 140 forks source link

Improved feature detection #45

Closed paulirish closed 8 years ago

paulirish commented 8 years ago

@patrickhlauke thanks for catching. Updated and simplified further.

RByers commented 8 years ago

Thanks! But I think this change mostly puts things back to how it was awhile ago.

@WebReflection argued in #30 that the try/catch wasn't enough to avoid syntax errors in old IE. And @marcoscaceres made the feature detect more verbose in #36

I'm happy to get rid of addEventListenerWithOptions though and add the new comments. I'll manually take the non-controversial improvements here and leave this PR open to discuss whether we should make any of the other remaining changes.

paulirish commented 8 years ago

sounds good! the manual changes you made are excellent.

thanks!