search

WICG / attribution-reporting-api

Attribution Reporting API
https://wicg.github.io/attribution-reporting-api/
Other
367 stars 173 forks source link

Omit source_registration_time field while excluding source registration time #1395

Closed linnan-github closed 3 months ago

linnan-github commented 3 months ago

This is compatible with currently supported aggregation service versions.

Preview | Diff

apasel422 commented 3 months ago

This is compatible with currently supported aggregation service versions.

I believe this to be true, but do we need to follow any kind of versioning requirements for the reports themselves?

linnan-github commented 3 months ago

This is compatible with currently supported aggregation service versions.

I believe this to be true, but do we need to follow any kind of versioning requirements for the reports themselves?

The version "1.0" supports this, so there's no change needed.

apasel422 commented 3 months ago

The version "1.0" supports this, so there's no change needed.

Is that specified somewhere? If so, please link to it.

linnan-github commented 3 months ago

The version "1.0" supports this, so there's no change needed.

Is that specified somewhere? If so, please link to it.

I don't think there's a link for this yet. We also omit the field for aggregatable debug reports, so there should not be an issue.

apasel422 commented 3 months ago

I don't think there's a link for this yet. We also omit the field for aggregatable debug reports, so there should not be an issue.

In that case, I'd suggest waiting to merge this until there's public documentation of the behavior here.

preethiraghavan1 commented 3 months ago

Aggregation Service assumes this field "source_registration_time" as optional, so omitting this is ok. This has always been the case, so there is no need for any version bump on the report for this.