WICG / background-sync

A design and spec for ServiceWorker-based background synchronization
https://wicg.github.io/background-sync/spec/
Apache License 2.0
640 stars 85 forks source link

Disallow periodic sync registrations from the background. #160

Closed mugdhalakhani closed 4 years ago

mugdhalakhani commented 4 years ago

This also updates some links to address the linking errors bikeshed emits after being updated.

@beverloo @jakearchibald PTAL.

mugdhalakhani commented 4 years ago

It's unfortunate that link-defauls keeps growing, even for something in WebIDL. Do we really need that?

The WebIDL reference has replaced a reference to promises-guide. So there's no net increase in link defaults because of that. I've tried running bikeshed using curl to rule out any staleness in my local bikeshed references, which means that these additions are indeed necessary to disambiguate between two references of the same name.

Without the 'resolve' default-link, I see this error:

Arbitrarily chose https://w3c.github.io/FileAPI/#blob-url-resolve To auto-select one of the following refs, insert one of these lines into a \

and without the "service worker" default-link, I see this error:

Arbitrarily chose https://w3c.github.io/ServiceWorker/#dfn-service-worker To auto-select one of the following refs, insert one of these lines into a \

Why do you think link-defaults are bad? I understand the concerns around adding to bikeshed anchors, but I'd like to understand your hesitation around adding to link-defaults. Happy to try another recommended way to disambiguate here. :)

mugdhalakhani commented 4 years ago

Thanks Peter. I'll ask around to see if there's a way around disambiguating with link defaults.