search

WICG / bfcache-not-restored-reason

Other
18 stars 5 forks source link

Property name nits #1

Closed domenic closed 2 years ago

domenic commented 2 years ago

Looking at the structures in https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md#examples and comparing to https://w3ctag.github.io/design-principles/#casing-rules , I would suggest url and id instead of URL and Id. (Since they are the first/only word in the name.)

Also, in JavaScript we use false and true, not False and True.

rubberyuzu commented 2 years ago

Done, thanks!

domenic commented 2 years ago

Hmm, I think I might have misled you on the URL and Id properties. I think they should be lowercase url and id, since they are the first word in their name :)

rubberyuzu commented 2 years ago

Ah my bad! Fixed :) Thanks!