search

WICG / capability-delegation

An API to allow developers transfer the ability to use restricted APIs to any target window in the frame tree.
Other
14 stars 7 forks source link

Add monkey-patch to support Fullscreen delegation #28

Closed mustaqahmed closed 2 years ago

mustaqahmed commented 2 years ago

Closes #10

mustaqahmed commented 2 years ago

@annevk PTAL

annevk commented 2 years ago

It would help me if #9 got explored more and also https://github.com/w3ctag/design-reviews/issues/655#issuecomment-953690813. I don't really see why we are doing this one API at a time and not set something up that scales better.

cc @domenic

domenic commented 2 years ago

I find @annevk's point compelling here, but from what I can tell this is the second delegated capability. IMO it's a fine working mode to start doing two things the longwinded/involved way, and then once those are established, do an editorial refactoring to make the call sites cleaner by abstracting away the shared logic.

I think that editorial refactoring should be a relatively high priority after landing this PR, though.

mustaqahmed commented 2 years ago

I would love to take a stab at #9 but that needs a bit of playing with more example capabilities. More importantly, I will need some 1:1s with two of you to sense some of the insights, currently I am struggling to start that work!

@annevk: Would it be okay with you if I merge this and then focus on the editorial refactoring as @domenic suggested?

annevk commented 2 years ago

That is okay with me, but do we have agreement on what I stated in my W3C TAG review comment? At least some people there seemed to have a very different idea about this and I'd like to be sure we have agreement on the bigger picture.

mustaqahmed commented 2 years ago

Let's plan for a meeting to discuss both the TAG comment and the refactoring idea. I will send out an email today.