search

WICG / compression-dictionary-transport

Other
92 stars 8 forks source link

Switch to W3C naming for dictionary keys #29

Closed pmeenan closed 1 year ago

pmeenan commented 1 year ago

Use full name for the dictionary keys to match W3C guidance on naming.

We may need to shorten them back as part of the IETF process but 3 characters in the default config of p to path or 9 when including e to expires isn't the end of the world.

Fix #27

pmeenan commented 1 year ago

FYI @horo-t

horo-t commented 1 year ago

lgtm

Created a Chromium side change: https://chromium-review.googlesource.com/c/chromium/src/+/4456368

pmeenan commented 1 year ago

Before I merge (and asked in the linked issue), I'm wondering if match makes more sense than path to make it clear that it is the URLs that the dictionary will be matched against.

yoavweiss commented 1 year ago

Given the use of wildcards, match may be better indeed.

pmeenan commented 1 year ago

I switched to match instead of path and changed the wording through the doc to make it clear that it is a URL-matching pattern (instead of all of the path language) and linked it directly to the existing URL spec and processing (the wildcard doesn't change the parsing or relative URL expansion bits).

I also fixed a few examples that were still using prefix matching instead of wildcards and updated the language in the examples to match the fully-expanded URL patterns.

horo-t commented 1 year ago

Still lgtm. Thank you. Updated the Chromium side CL. https://chromium-review.googlesource.com/c/chromium/src/+/4456368