search

WICG / compression-dictionary-transport

Other
92 stars 8 forks source link

Add out-of-scope statement for websockets #33

Closed pmeenan closed 11 months ago

pmeenan commented 1 year ago

Fix #30

pmeenan commented 1 year ago

Sorry, I'll update the title. Previous versions had more details but then I got to thinking that compression on websockets could be quite a bit different and that I shouldn't make assumptions about how it would be implemented.

On Mon, May 1, 2023 at 8:16 AM Yoav Weiss @.***> wrote:

@.**** approved this pull request.

This language LGTM, but it doesn't expand a whole lot on the use-case itself.. I guess that's fine (but the title made me think it would)

— Reply to this email directly, view it on GitHub https://github.com/WICG/compression-dictionary-transport/pull/33#pullrequestreview-1407551340, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADMOBKL4SRJVEG3YCWAMGLXD6STVANCNFSM6AAAAAAXLJM3CA . You are receiving this because you authored the thread.Message ID: @.*** com>

yoavweiss commented 11 months ago

This PR got (mistakenly) updated when #40 was uploaded

pmeenan commented 11 months ago

Sorry about that - reset the branch back to where it was.