Closed ayuishii closed 4 years ago
Per recommendation from kenchris@ via TAG discussion
Change set() method to be as follows
set()
Before
Promise<void> set(USVString name, USVString value, optional CookieStoreSetOptions options = {}); Promise<void> set(CookieStoreSetExtraOptions options); dictionary CookieStoreSetOptions { DOMTimeStamp? expires = null; USVString? domain = null; USVString path = "/"; CookieSameSite sameSite = "strict"; }; dictionary CookieStoreSetExtraOptions : CookieStoreSetOptions { required USVString name; required USVString value; };
After
Promise<void> set(USVString name, USVString value); Promise<void> set(CookieListItemInit cookieListItemInit); dictionary CookieListItemInit { required USVString name; USVString value; USVString? domain = null; USVString path = "/"; DOMTimeStamp? expires = null; CookieSameSite sameSite = "strict"; };
Maybe rename CookieListItemInit to just CookieInit ?
CookieListItemInit
CookieInit
CookieInit SGTM 👍
Spec change and implementation complete, thanks!
Per recommendation from kenchris@ via TAG discussion
Change
set()
method to be as followsBefore
After