WICG / cookie-store

Asynchronous access to cookies from JavaScript
https://wicg.github.io/cookie-store/
Apache License 2.0
143 stars 35 forks source link

Update `set()` method to use CookieInit #139

Closed ayuishii closed 4 years ago

ayuishii commented 4 years ago

Per recommendation from kenchris@ via TAG discussion

Change set() method to be as follows

Before

 Promise<void> set(USVString name, USVString value,
                    optional CookieStoreSetOptions options = {});
 Promise<void> set(CookieStoreSetExtraOptions options);

dictionary CookieStoreSetOptions {
  DOMTimeStamp? expires = null;
  USVString? domain = null;
  USVString path = "/";
  CookieSameSite sameSite = "strict";
};

dictionary CookieStoreSetExtraOptions : CookieStoreSetOptions {
  required USVString name;
  required USVString value;
};

After

  Promise<void> set(USVString name, USVString value);
  Promise<void> set(CookieListItemInit cookieListItemInit);

dictionary CookieListItemInit {
  required USVString name;
  USVString value;
  USVString? domain = null;
  USVString path = "/";
  DOMTimeStamp? expires = null;
  CookieSameSite sameSite = "strict";
};
inexorabletash commented 4 years ago

Maybe rename CookieListItemInit to just CookieInit ?

ayuishii commented 4 years ago

CookieInit SGTM 👍

ayuishii commented 4 years ago

Spec change and implementation complete, thanks!