search

WICG / cookie-store

Asynchronous access to cookies from JavaScript
https://wicg.github.io/cookie-store/
Apache License 2.0
143 stars 35 forks source link

Add references to the HTML specification for secure/non-secure contexts #194

Closed fred-wang closed 3 years ago

fred-wang commented 3 years ago

This commit links "secure context" to https://html.spec.whatwg.org/multipage/webappapis.html#secure-context

and rename "unsecure context" to "non-secure context" in order to match https://html.spec.whatwg.org/multipage/webappapis.html#non-secure-context

Preview | Diff

fred-wang commented 3 years ago

Hopefully this is the definition meant by "secure context" and "unsecure context". Note that I replaced one "unsecured http context" by just "non-secure context", but I think "http" is not important here.

fred-wang commented 3 years ago

I wonder if the "origin" should be replaced with "context" here too: https://wicg.github.io/cookie-store/#gotcha to avoid confusion with "potentially trustworthy origin".

inexorabletash commented 3 years ago

LGTM, can you follow the instructions at https://labs.w3.org/repo-manager/pr/id/WICG/cookie-store/194 to link accounts?

fred-wang commented 3 years ago

LGTM, can you follow the instructions at https://labs.w3.org/repo-manager/pr/id/WICG/cookie-store/194 to link accounts?

Done (finally!). Let's see if that works....

inexorabletash commented 3 years ago

Can you make a whitespace change and push to get a clean Travis-CI build?

inexorabletash commented 3 years ago

Also, you may have to join WICG, button on: https://www.w3.org/community/wicg/

fred-wang commented 3 years ago

@inexorabletash Not sure what's happening. Travis fails with "bikeshed update" and I joined the WICG group.

inexorabletash commented 3 years ago

https://github.com/w3c/ash-nazg/issues/201 may be to blame. Let's give it the weekend to get sorted out.

inexorabletash commented 3 years ago

Or I can just force merge it...

fred-wang commented 3 years ago

Thanks!