Normative: get()'s promise should resolve to null, not undefined - Githubissues

WICG / cookie-store

Asynchronous access to cookies from JavaScript

https://wicg.github.io/cookie-store/

Apache License 2.0

143 stars 35 forks source link

Normative: get()'s promise should resolve to null, not undefined #217

Closed inexorabletash closed 1 year ago

inexorabletash commented 1 year ago

The spec and tests were inconsistent:

In the spec's IDL, the inner type of the promise returned by get() is nullable.
In the spec's prose, the steps call for resolving the promise with undefined.
In WPT, the tests[1] assert that the promise is resolved with null.

The Chromium implementation[2] matched the tests, not the spec prose.

Investigation documented in #210 indicates it is likely not web-compatible to make this change purely for idealistic reasons.

Resolves #210.

[1] example: https://github.com/web-platform-tests/wpt/blob/master/cookie-store/cookieStore_delete_arguments.https.any.js

[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/cookie_store/cookie_store.cc;l=482

inexorabletash commented 1 year ago

@ayuishii & @annevk - this look okay?