Fix `Set A Cookie` Algorithm

ayuishii commented 3 months ago

Addresses issue: https://github.com/WICG/cookie-store/issues/227

Updates "Set a Cookie" algorithm to not null check path as it should always be populated
Updates set method to call algorithm with all non-optional parameters

inexorabletash commented 3 months ago

    $ bikeshed --die-on=fatal spec "index.bs" "index.bs.built.html" 
      LINE ~1271: Couldn't find section '#section-5.7.3' in spec 'rfc6265bis':
      [[RFC6265bis#section-5.7.3]]
       ✘  Did not generate, due to errors exceeding the allowed error level.
    Command `bikeshed --die-on=fatal spec "index.bs" "index.bs.built.html" ` failed with exit code: 2.

Unfortunately the RFC renumbered things. Fortunately Bikeshed actually catches this now, which is awesome. I think I made a local PR to update the numbers a while ago, which may or may not still be valid. Let me take a look...

inexorabletash commented 3 months ago

Ah, the latest rfc6265bis has named anchors. Let me see if I can get a PR together quickly...

ayuishii commented 3 months ago

Wohoo, passed! Thanks @inexorabletash !

WICG / cookie-store

Fix `Set A Cookie` Algorithm #231