Closed Mr0grog closed 9 years ago
Fixed the links manually. The commit seems to be modifying the index.html file too? We will regenerate that one.
The commit seems to be modifying the index.html file too?
Yeah, noted that above. I’m assuming I have a newer version of bikeshed than whoever last generated it. Either that or there’s some configuration I need to do that’s not captured in tidyconfig.txt
.
@Mr0grog really sorry, I didn't read the third para. I'm not sure who is handling the regeneration of this doc.
@Mr0grog ok, regenerated the doc and pushed it. Thanks again for spotting the issue with the links! Sorry about the extra work I kinda threw away :(
No worries, happy to help out. For future reference, when you regenerated the HTML, did it come out the same as mine, or is there additional configuration I need?
Doing a quick compare, it's a bit different. For instance, line 385.
/* Switch/case <dl>s */
I don't think you need any additional config. Maybe just pull down the latest bikeshed and reinstall.
Hmmmm, I’d never used it before, so what I generated with should have been the latest as of the date I opened the pull request. Maybe something newer now, though.
Just updated and it’s pretty close to the same as what you got. So I guess I was on a newer version and it’s changed again since :P
BS is updated fairly frequently. Ideally, what we need to do is have BS run through something like Travis.ci, which should pull down the latest BS, and generated the spec, without us needing to worry about having to regenerate the spec manually.
Anyway, we will work that out over time.
For now, note that BS is usable from a web API https://api.csswg.org/bikeshed/. No need to install anything if you're infrequently using it, or are ok with network roundtrips.
Oh, that’s really nice! Thanks, @tabatkins.
ooohh! that's quite handy ssshmandy!
Y'all should read project READMEs more often. ^_^
Gah, must have breezed right over that note! Oops :\
heh, I actually did that yesterday when (re)installing BS locally. I totally missed this.
@tabatkins FWIW, might be worth noting that in the install and quickstart docs, too. I’d bet a lot of people skim the readme for specifically those items and miss the bit about being able to use it as an web API. Or maybe just make a big heading about it in the README. (Which is not to excuse my poor reading :P )
Agree with @Mr0grog. If we both missed this, then it's a usability issue with the README.
Makes sense. Done.
@tabatkins Thanks!
Just noticed a couple bad links for open and closed issues—they were pointing to the ResponsiveImages/ri-usecases repo instead of ResponsiveImages/eq-usecases.
Sorry if I should’ve made a bug for this; figured since it’s basically just a typo correction it wasn’t worthwhile.
There are also a lot of changes in the generated HTML file here. They all look like they are mostly just formatting—I’m assuming I’ve got a newer version of bikeshed than whoever/whenever last updated this. If not or if I’ve got something configured wrong, let me know.