Closed beaufortfrancois closed 1 year ago
Hmm that probably makes sense. My main concern was the given that the window size is restricted and we don't currently have a way to give the website those restrictions, it seems like it could be easier for them to just specify an aspect ratio. That said, if you think we should change it so that ones that fall outside the range try to keep aspect ratio anyway, then maybe that's okay. WDYT? Do we know of anyone who was planning on using aspect ratio?
I'm happy with using initialAspectRatio
only as well.
We have some partners who would definitely prefer to have width and height parameters, so I don't think we'd want to remove them
Fixed by #36
With
lockAspectRatio
gone, I think we should removeinitialAspectRatio
from the spec and tell web developers to only usewidth
andheight
to set the desired PiP window size. We could make sure that the aspect ratio is respected as well when specifying those implementation wise.can be replaced with
@steimelchrome What do you think?