search

WICG / element-timing

A proposal for an Element Timing specification.
https://wicg.github.io/element-timing/
Other
58 stars 15 forks source link

Use URL serializer #66

Closed npm1 closed 2 years ago

npm1 commented 2 years ago

Fixes https://github.com/WICG/element-timing/issues/62 and https://github.com/WICG/element-timing/issues/63 @annevk

Preview | Diff

npm1 commented 2 years ago

It seems resolved URL is the wrong concept here. If this holds an image request, you want https://html.spec.whatwg.org/multipage/images.html#img-req-url, right?

Yea, that sounds good.

As that's already a string, you'll have to parse it to determine the scheme. (Although also, this seems like a flaw there, it should have been a URL.)

Done

Do we need to strip things like username/password/fragment? It probably doesn't matter here, or are these also reported outside of this specific object in some way?

Not reported outside of this object.

A URL's scheme doesn't include the colon. (Existing error.)

Done

npm1 commented 2 years ago

I guess I need to wait a day or so for bikeshed to pick up the new exports? I tried bikeshed update just now and it still does not pick up the new exports added on HTML. I can try again on Monday.

annevk commented 2 years ago

Yeah, generally it takes about a day. If it continues failing I recommend reaching out to Tab Atkins.

npm1 commented 2 years ago

Does this look good @annevk?

npm1 commented 2 years ago

Sounds good, filed https://github.com/WICG/element-timing/issues/67