search

WICG / entries-api

Spec defining browser support for file/directory upload by drag-and-drop
https://wicg.github.io/entries-api/
Other
41 stars 9 forks source link

Use callback functions instead of callback interfaces #23

Closed foolip closed 6 years ago

foolip commented 6 years ago

Happily, the prose was already using https://heycam.github.io/webidl/#es-invoking-callback-functions instead of https://heycam.github.io/webidl/#call-a-user-objects-operation, which makes it correct now.

Fixes https://github.com/WICG/entries-api/issues/3.

foolip commented 6 years ago

This also needs tests. @inexorabletash, would it suffice to test that passing an object (that is not a function) as the callback arguments throws TypeError, or has there ever been an implementation that exposed interface objects for these that I should write historical tests for?

inexorabletash commented 6 years ago

would it suffice to test that passing an object (that is not a function) as the callback arguments throws TypeError

I think that's the best we can do.

inexorabletash commented 6 years ago

Change looks good; I'll merge once I'm back in the office since this repo still requires manual bs→html generation.