WICG / fenced-frame

Proposal for a strong boundary between a page and its embedded content
https://wicg.github.io/fenced-frame/
Other
123 stars 31 forks source link

Spec reportEvent to custom destination URLs with macro substitution #113

Closed gtanzer closed 11 months ago

gtanzer commented 1 year ago

Preview | Diff

gtanzer commented 1 year ago

@qingxinwu Thanks for reviewing! Fixed all the comments.

gtanzer commented 11 months ago

To be merged after https://github.com/WICG/fenced-frame/pull/117 , which creates [=fencedframeutil/substitute macros=].

domfarolino commented 11 months ago

To be merged after https://github.com/WICG/fenced-frame/pull/117 , which creates [=fencedframeutil/substitute macros=].

Sounds good, I think this mostly looks good so let's wait until that gets landed then.

qingxinwu commented 11 months ago

LGTM.