search

WICG / fenced-frame

Proposal for a strong boundary between a page and its embedded content
https://wicg.github.io/fenced-frame/
Other
124 stars 31 forks source link

[Spec] Clean up + fix outdated navigation references #181

Open blu25 opened 3 weeks ago

blu25 commented 3 weeks ago

The navigate algorithm has changed since we originally monkey patched it. This PR updates our monkey patch to reference the steps as they currently exist. This also cleans up the Should navigation response to navigation request be blocked by Permissions Policy? definition to match the formatting of other algorithms.

See issue: https://github.com/WICG/fenced-frame/issues/179

Preview | Diff

domfarolino commented 2 weeks ago

This also cleans up the Should navigation response to navigation request be blocked by Permissions Policy? definition to match the formatting of other algorithms.

Other algorithms in our spec, or in HTML? The current declaration of that algorithm seems pretty good / clear, what's wrong with it?

blu25 commented 2 weeks ago

This also cleans up the Should navigation response to navigation request be blocked by Permissions Policy? definition to match the formatting of other algorithms.

Other algorithms in our spec, or in HTML? The current declaration of that algorithm seems pretty good / clear, what's wrong with it?

Most algorithms in our spec don't start with "Create a new algorithm called X..." but instead either just define the algorithm's name or state "To do X given Y, run these steps:". I think it's better for this algorithm to try to match the latter for consistency.