search

WICG / fenced-frame

Proposal for a strong boundary between a page and its embedded content
https://wicg.github.io/fenced-frame/
Other
124 stars 31 forks source link

Remove unused config size attributes #182

Closed VergeA closed 1 week ago

VergeA commented 3 weeks ago

The IDL containerWidth, containerHeight, contentWidth, and contentHeight attributes not actually implemented in Chromuim, so we should remove them.

Additionally, the internal fenced frame config struct does not implement container size, only content size. So we should remove that as well.

Preview | Diff

domfarolino commented 3 weeks ago

Is this ready for review?

VergeA commented 2 weeks ago

Yes, sorry! I don't think I have the proper permissions on the repo to add reviewers myself.

domfarolino commented 2 weeks ago

Before I merge, can I ask @blu25 to take a quick look too? Just since you all are more familiar with the latest FF implementation than me at the moment.

VergeA commented 2 weeks ago

Thanks for the review Dom! And yep, sounds good.